Skip to content

Conversation

Noratrieb
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2023
@lcnr
Copy link
Contributor

lcnr commented Jan 17, 2023

❤️ r=me with fixed ci

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned TaKO8Ki Jan 17, 2023
@Noratrieb Noratrieb force-pushed the _use_mk_manual_debug_impl_instead branch 2 times, most recently from c21edc3 to c06e37f Compare January 17, 2023 13:30
@Noratrieb Noratrieb force-pushed the _use_mk_manual_debug_impl_instead branch from c06e37f to cb00bc0 Compare January 17, 2023 14:04
@Noratrieb
Copy link
Member Author

turns out you need to use things to use their names
@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Jan 17, 2023

📌 Commit cb00bc0 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104505 (Remove double spaces after dots in comments)
 - rust-lang#106784 (prevent E0512 from emitting [type error] by checking the references_error)
 - rust-lang#106834 (new trait solver: only consider goal changed if response is not identity)
 - rust-lang#106889 (Mention the lack of `windows_mut` in `windows`)
 - rust-lang#106963 (Use `scope_expr_id` from `ProbeCtxt`)
 - rust-lang#106970 (Switch to `EarlyBinder` for `item_bounds` query)
 - rust-lang#106980 (Hide `_use_mk_alias_ty_instead` in `<AliasTy as Debug>::fmt`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48bd3ab into rust-lang:master Jan 18, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 18, 2023
@Noratrieb Noratrieb deleted the _use_mk_manual_debug_impl_instead branch January 18, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants